-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease refcount for subscriber #3493
Conversation
Good catch! That It's worth mentioning there is no strict evidence in the group discussion that can correlate the observed leak with the slow-link events. The refcount dump just mentions many calls to
Nevertheless slow-links could explain that leak and the patch looks good. |
janus_videoroom_slow_link calls janus_videoroom_session_get_subscriber which increments the refcount and the logger logs it as janus_videoroom_session_get_subscriber because the refcount increases from it, so it's one of that calls |
Yes I know how refcount debugging works. I just meant there are several potential entry points for |
I agree that's the likely culprit. Let me check if it's there in 0.x too and then I'll merge (and in case backport). |
It's missing there too, so I'll cherry-pick the commit after the merge. Thanks! |
Noticed a suspiciously missing janus_refcount_decrease which could be the cause of this leak