Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make scrollbar vertically and horizontally centered #1036

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

lucasoares
Copy link
Contributor

@lucasoares lucasoares commented Jan 13, 2025

Description

Fixes the scrollbar UI making it correctly vertically centered

Behavior

Actual

image

image

Expected

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@lucasoares lucasoares changed the title fix: make scrollbar vertically centered fix: make scrollbar vertically and horizontally centered Jan 13, 2025
@nekiro nekiro merged commit 69352a9 into mehah:main Jan 13, 2025
12 checks passed
@kokekanon
Copy link
Collaborator

kokekanon commented Jan 13, 2025

ehm in my particular case. the change looks like this.

client_options work fine

image

@nekiro
Copy link
Collaborator

nekiro commented Jan 13, 2025

ehm in my particular case. the change looks like this.

client_options work fine

image

Isn't this a different kind of scrollbar? It's not QT one

@nekiro
Copy link
Collaborator

nekiro commented Jan 13, 2025

Oh right. I did not notice changes in regular scrollbars, mb. These changes are definitely wrong in base styles. I'll fix it tomorrow if no one does.

@lucasoares
Copy link
Contributor Author

lucasoares commented Jan 14, 2025

ehm in my particular case. the change looks like this.

client_options work fine

image
image

With my changes this is the result for me. No issues. Weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants