fix: ActionBar packets (sendEquipItem) + Tier in actionbar #1073
Conversation
kokekanon
changed the title
|
As far as I'm aware, this feature was introduced together with the exaltation forge so it can be enabled since 12.80 (or generally be a part of "forge packets" feature) 13.20 private repo void ProtocolGame::parseEquipObject(NetworkMessage& msg)
{
// action bar/hotkey equip
uint16_t clientId = msg.get<uint16_t>();
const ItemType& it = g_items.legacyGetItemTypeByClientId(clientId);
if (it.id == 0) {
return;
}
uint8_t tier = 0;
if (it.classification > 0) {
tier = msg.getByte();
}
g_gameThread.addTask(createTask((DISPATCHER_TASK_EXPIRATION, [=, playerID = player->getID(), isTiered = it.classification > 0]() { g_game.playerEquipItem(playerID, clientId, isTiered, tier); })));
} |
src/client/protocolgamesend.cpp
Outdated
| else | ||
| msg->addU8(static_cast<uint8_t>(countOrSubType)); | ||
| if (g_game.getFeature(Otc::GameThingUpgradeClassification)) | ||
| msg->addU8(tier); |
There was a problem hiding this comment.
while there are no items that have both: "cloth" and "liquid pool"/"liquid container" flags together in the vanilla client, the client is coded to send TIER or FLUID CLIENT ID in the protocol (this applies for both "equip" and "use" actions)
in short: the client should send either TIER or FLUID CLIENT ID in hotkey equip/use
(I've also tried combining classification with liquid container, but qt client refuses to load assets when both flags are present)
video (qt client, I added "cloth" flag with "arrow" slot to vials and set "equip" action on them):
2025-01-25.13-38-58.mp4
There was a problem hiding this comment.
Im an 8.6 player, not using versions 13, my knowledge is limited, which item allows to be equip / unequip and have getCountOrSubType ? in default assets
|
equipping items works now 2025-01-25.15-20-14.mp4relogging changes fluid subtype 2025-01-25.15-21-15.mp4 |
|
when I made the modification, I didn't realize that tibiaQT doesn't show the tiers in the actionbar, ups me bad. |
the bug I see is :
for me, it needs to be done from 0🤣 A 6-year-old module was not designed for Tibia 13. |
Tibia 14 has this fixed if I remember correctly |
|
Description
The function sendEquipItem (which only affects game_actionbar) was sending 2 packets:
according OTCR
u16 the itemId
u8 or u16 countOrSubType
But this is incorrect.
According to Canary, the 2 packets to send are:
u16 the itemId
u8 tier.
This error manifests when trying to equip an item with a tier through the action bar.
The client sends the itemId and count (1).
For example, attempting to equip an Helmet tier +5.
The server interprets itemId and tier = 1(count), failing to find the item.
As a result, it doesn't work.
Canary 13.40
2 packets:
U16 item ID
u8 Tier
https://github.com/opentibiabr/canary/blob/5781de718e5d22ce9e7f136151d8b4032c85843d/src/server/network/protocol/protocolgame.cpp#L1392-L1400
Tfs 10.98 blacktek
only packet U16 Item ID ( no have this feature GameThingUpgradeClassification)
https://github.com/Black-Tek/BlackTek-Server/blob/7130b41899fcb643b582e78a52ff27e891110d54/src/protocolgame.cpp#L983-L989
tfs forgottenserver-optimized SaiyansKing
only packet U16 Item ID ( no have this feature GameThingUpgradeClassification)
https://github.com/mehah/forgottenserver-optimized/blob/148baaa48c8ca159b16d0b632bd813749399b013/src/protocolgame.cpp#L1256-L1262
tfs 8.6
does not have this function
tfs 13.10
13.10 does not have many features, this is one of them
https://github.com/otland/forgottenserver/blob/b227678ab3584b8349913abfe4529292678a3fdf/src/protocolgame.cpp#L1300-L1308
Behavior
Actual
Expected
Fixes
usser in discord
Type of change
How Has This Been Tested
Test Configuration:
Checklist