Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple errors produced in # 621 #712

Merged
merged 8 commits into from
Mar 2, 2024
Merged

fix: multiple errors produced in # 621 #712

merged 8 commits into from
Mar 2, 2024

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Mar 2, 2024

Description

1.- fix: missing font [1]

image
image

2.- fix: Error console [2]

ERROR: [BOT] [string "/vBot/extras.lua"]:584: attempt to concatenate local 'voc' (a nil value)

3.- fix: impossible to click checkbox [3]

image

4.- fix: crash (patch solution) [4]

patch solution
Note:
I haven't used a bot in mehah for a long time, this was final beta testing.
crash

or comments this https://github.com/mehah/otclient/blob/main/mods/game_bot/default_configs/vBot_4.8/_Loader.lua#L26

5.- cleaning: remove incessant print [5]

image

6.- Fix: isEnabledWASD was only updated on login

image

7.- fix: Panels/widgets not saving positions #703

solve #703
ttt

8.- fix: unnecessary loading of websocket

image

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
    .

.

Missing fixes:

i don't think anyone will fix, but I posted some bugs that I remember as a reminder or log (I don't use bot for a long time):

1.- the function indeed opens the file explorer but not the correct directory.

g_platform.openDir("%appdata%/otcr") not work

image
image
notified in discord by "@ el_discreto" ,
possible solution by "@ zbizu".

2.- buttons freeze (I don't know how this happens)

image

3.- bug that didn't save(instantly) the bot's configuration of game_itemselector maybe the .json file didn't update correctly.

tttccc

@kokekanon kokekanon changed the title Fix multiple errors produced in # 621 fix: multiple errors produced in # 621 Mar 2, 2024
@kokekanon
Copy link
Collaborator Author

kokekanon commented Mar 2, 2024

image

today 02/03/2024
I cannot reproduce this error

This was fixed here https://github.com/mehah/otclient/issues/681
6fbbfd9

and was not caused by the commits. https://github.com/mehah/otclient/issues/621

@mehah mehah merged commit 64338a5 into mehah:main Mar 2, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants