-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: packet Canary PR : "cyclopedia house auction" # 3022 #970
Draft
kokekanon
wants to merge
20
commits into
mehah:main
Choose a base branch
from
kokekanon:fix-warning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
47cb9dd
fix: packet cyclopedia house auction Canary PR # 3022
kokekanon 06a34a3
fix: Sonarbot string_view to string
kokekanon c58eb8f
fix: sonar (Auto | Use the init-statement to declare "isOwner" inside…
kokekanon 6ec2fe1
fix: sonar Use the init-statement to declare "isRented" inside the if…
kokekanon b3d9a41
Merge branch 'main' into fix-warning
Nottinghster 48c9645
Update src/client/protocolgame.h
kokekanon 79fd222
Update src/client/game.cpp
kokekanon d6bcada
Update src/client/game.h
kokekanon 7d4df98
Update src/client/protocolgameparse.cpp
kokekanon 55f6a1e
Update src/client/protocolgameparse.cpp
kokekanon 793c2d4
Update src/client/protocolgamesend.cpp
kokekanon b9e1788
Update src/client/protocolgamesend.cpp
kokekanon e41f07d
Update src/client/protocolgamesend.cpp
kokekanon f5e8b40
Update src/client/protocolgamesend.cpp
kokekanon 2149b6f
Update src/client/protocolgamesend.cpp
kokekanon 48c36c7
Merge branch 'main' into fix-warning
kokekanon b3a1691
Merge remote-tracking branch 'upstream/main' into fix-warning
kokekanon 9aa5037
Merge remote-tracking branch 'upstream/main' into fix-warning
kokekanon 024c47b
Merge branch 'main' into fix-warning
Nottinghster 8c49c69
Merge branch 'main' into fix-warning
mehah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that before, but sonarbot sends that recommendation.
"-Use the init-statement to declare "typeValue" inside the if statement."