Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Drop hard requirement on ReactActivity and use Activity ins… #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,24 @@
import android.app.Dialog;
import android.graphics.Color;

import com.facebook.react.ReactActivity;
import com.facebook.react.ReactInstanceManager;
import com.facebook.react.bridge.ReactContext;

import java.lang.ref.WeakReference;

public class SplashScreen {
private static Dialog mSplashDialog;
private static WeakReference<ReactActivity> mActivity;
private static WeakReference<Activity> mActivity;

/**
* Show the splash screen.
*/
public static void show(final ReactActivity activity, final ReactInstanceManager instanceManager) {
public static void show(final Activity activity, final ReactInstanceManager instanceManager) {
if (activity == null) return;

// Store weak-reference to showing activity (in case we try to hide too early)
// NOTE: For instance in direct execution of index.android.js
mActivity = new WeakReference<ReactActivity>(activity);
mActivity = new WeakReference(activity);

activity.runOnUiThread(new Runnable() {
@Override
Expand Down