updated _is_field_type_a_primitive_array #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types like `double[x]` were passing through `_is_field_type_a_primitive_array()` undetected, and `get_fields_and_field_types` was being called on a python list (which fails). this fixes that. validated with a complex message `sensor_msgs/msg/NavSatFix`. also validated that the generated JSON is correctly converted back into a ROS2 message.
…detection updated _is_field_type_a_primitive_array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types like double[x] were passing through _is_field_type_a_primitive_array() undetected, and get_fields_and_field_types was being called on a python list (which fails). this fixes that. validated with a complex message sensor_msgs/msg/NavSatFix. also validated that the generated JSON is correctly converted back into a ROS2 message.