This repository has been archived by the owner on Feb 18, 2019. It is now read-only.
forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reviewed By: mkonicek Differential Revision:D3054232 Ninja: oss only fb-gh-sync-id: 6cb9b361f62c1bc009a412049b47be99c423d6e9 shipit-source-id: 6cb9b361f62c1bc009a412049b47be99c423d6e9
- Loading branch information
Martin Konicek
authored and
Facebook Github Bot 7
committed
Mar 15, 2016
1 parent
e07fe0c
commit 0a35529
Showing
1 changed file
with
4 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,12 @@ | ||
| ## Tips on reviewing pull requests | ||
|
|
||
| Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Ask for it and link to the template. Add labels 'Needs revision' and 'Needs response from author'. Examples: [#6395](https://github.com/facebook/react-native/pull/6395). | ||
| Example: | ||
| Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Example: [#6395](https://github.com/facebook/react-native/pull/6395). Add labels 'Needs revision' and 'Needs response from author'. Add a response like: | ||
|
|
||
| > Hey @author, thanks for sending the pull request. | ||
| > Can you please add all the info specified in the [template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? This is necessary for people to be able to understand and review your pull request. | ||
| Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'. | ||
| Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency (formatting, naming) with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'. | ||
|
|
||
| Does the pull request add a completely new feature we don't want to add to the core and maintain? Ask the author to release it a separate npm module. | ||
| Does the pull request add a completely new feature we don't want to add to the core and maintain? Ask the author to release it a separate npm module and close the PR. Example: [#2648](https://github.com/facebook/react-native/pull/2648). | ||
|
|
||
| Does the pull request do several unrelated things at the same time? Ask the author to split it. | ||
| Does the pull request do several unrelated things at the same time? Ask the author to split it. |