Fix showing RCTPerformanceLogger data

Reviewed By: nicklockwood Differential Revision: D3064023 fb-gh-sync-id: df9358dddfcc79e12a65a8b9c182615be64fc468 shipit-source-id: df9358dddfcc79e12a65a8b9c182615be64fc468
meituan · Mar 17, 2016 · 24f7d88 · 24f7d88
1 parent 55477ff
commit 24f7d88
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/React/Base/RCTPerformanceLogger.m b/React/Base/RCTPerformanceLogger.m
@@ -101,6 +101,7 @@ void RCTPerformanceLoggerAppendEnd(RCTPLTag tag)
       @"NativeModuleMainThread",
       @"NativeModulePrepareConfig",
       @"NativeModuleInjectConfig",
+      @"NativeModuleMainThreadUsesCount",
       @"JSCExecutorSetup",
       @"RootViewTTI",
       @"BundleSize",

diff --git a/React/Profiler/RCTPerfMonitor.m b/React/Profiler/RCTPerfMonitor.m
@@ -506,7 +506,12 @@ - (void)loadPerformanceLoggerData
   NSArray<NSNumber *> *values = RCTPerformanceLoggerOutput();
   for (NSString *label in RCTPerformanceLoggerLabels()) {
     long long value = values[i+1].longLongValue - values[i].longLongValue;
-    NSString *unit = [label isEqualToString:@"BundleSize"] ? @"b" : @"ms";
+    NSString *unit = @"ms";
+    if ([label hasSuffix:@"Size"]) {
+      unit = @"b";
+    } else if ([label hasSuffix:@"Count"]) {
+      unit = @"";
+    }
     [data addObject:[NSString stringWithFormat:@"%@: %lld%@", label, value, unit]];
     i += 2;
   }