Upgrade folly dependency

Summary: Folly deprecated the brace initialization for dynamic::array, so point to a more recent tarball and fix it.

Reviewed By: bestander

Differential Revision: D3066402

fb-gh-sync-id: aaf70423886cb0cbc14aba7878a1d4e32bce82b1
shipit-source-id: aaf70423886cb0cbc14aba7878a1d4e32bce82b1

ReactAndroid/build.gradle

@@ -55,17 +55,17 @@ task prepareDoubleConversion(dependsOn: downloadDoubleConversion, type: Copy) {
 }
 
 task downloadFolly(dependsOn: createNativeDepsDirectories, type: Download) {
-    src 'https://github.com/facebook/folly/archive/v0.50.0.tar.gz'
+    src 'https://github.com/facebook/folly/archive/deprecate-dynamic-initializer.tar.gz'
     onlyIfNewer true
     overwrite false
-    dest new File(downloadsDir, 'folly-0.50.0.tar.gz');
+    dest new File(downloadsDir, 'folly-deprecate-dynamic-initializer.tar.gz');
 }
 
 task prepareFolly(dependsOn: downloadFolly, type: Copy) {
     from tarTree(downloadFolly.dest)
     from 'src/main/jni/third-party/folly/Android.mk'
-    include 'folly-0.50.0/folly/**/*', 'Android.mk'
-    eachFile {fname -> fname.path = (fname.path - "folly-0.50.0/")}
+    include 'folly-deprecate-dynamic-initializer/folly/**/*', 'Android.mk'
+    eachFile {fname -> fname.path = (fname.path - "folly-deprecate-dynamic-initializer/")}
     includeEmptyDirs = false
     into "$thirdPartyNdkDir/folly"
 }

ReactAndroid/src/main/jni/react/jni/BUCK

@@ -70,7 +70,6 @@ jni_library(
   compiler_flags = [
     '-Wall',
     '-Werror',
-    '-Wno-deprecated-declarations',
     '-fexceptions',
     '-std=c++11',
     '-fvisibility=hidden',

ReactAndroid/src/main/jni/react/jni/OnLoad.cpp

@@ -235,7 +235,7 @@ struct WritableNativeArray
   static constexpr const char* kJavaDescriptor = "Lcom/facebook/react/bridge/WritableNativeArray;";
 
   WritableNativeArray()
-      : HybridBase(folly::dynamic({})) {}
+      : HybridBase(folly::dynamic::array()) {}
 
   static local_ref<jhybriddata> initHybrid(alias_ref<jclass>) {
     return makeCxxInstance();