Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AbortSignal and aborted binding #47

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Add AbortSignal and aborted binding #47

merged 3 commits into from
Mar 12, 2024

Conversation

bryanthomaschen
Copy link
Contributor

This PR adds the aborted binding under a new AbortSignal module.
API reference for AbortSignal.aborted

anmonteiro
anmonteiro reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoudl we

src/Fetch.ml Show resolved Hide resolved
src/Fetch.mli Show resolved Hide resolved
bryanthomaschen and others added 2 commits March 12, 2024 11:39
@bryanthomaschen @anmonteiro
Add reason field
eb79435 
Co-authored-by: Antonio Nuno Monteiro <[email protected]>
@bryanthomaschen @anmonteiro
Add reason to src/Fetch.mli
4d9125c 
Co-authored-by: Antonio Nuno Monteiro <[email protected]>
@anmonteiro
Copy link
Member

Thanks!

@anmonteiro anmonteiro merged commit c5803ab into melange-community:master Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro Awaiting requested review from anmonteiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanthomaschen @anmonteiro