Skip to content

Commit

Permalink
Merge pull request #171 from DavidLevinsky/master
Browse files Browse the repository at this point in the history
Fixed dynamic labels size
  • Loading branch information
davidmtech authored Oct 29, 2019
2 parents dfc092c + 3e23b29 commit 8fdd34b
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 16 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vts-browser-js",
"version": "2.22.5",
"version": "2.22.6",
"description": "JavaScript WebGL 3D maps rendering engine",
"main": "src/browser/index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/core/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ string getCoreVersion()
*/

function getCoreVersion(full) {
return (full ? 'Core: ' : '') + '2.22.5';
return (full ? 'Core: ' : '') + '2.22.6';
}


Expand Down
6 changes: 3 additions & 3 deletions src/core/renderer/draw.js
Original file line number Diff line number Diff line change
Expand Up @@ -1709,7 +1709,7 @@ RendererDraw.prototype.drawGpuJob = function(gpu, gl, renderer, job, screenPixel
for(j = 0; j < points.length; j++) {
pp = renderer.project2(points[j], mvp, [0,0,0], true);
this.drawCircle(pp, points[j][3] *renderer.camera.scaleFactor2(pp[3])*0.5*renderer.curSize[1], 1, [255, 0, 255, 255], null, null, null, null, null);
this.drawCircle(pp, points[j][3] *renderer.camera.scaleFactor2(pp[3])*0.5*renderer.curSize[1]*(renderer.curSize[0]/renderer.curSize[1]), 1, [255, 0, 255, 255], null, null, null, null, null);
}
}
}*/
Expand Down Expand Up @@ -2773,8 +2773,8 @@ RendererDraw.prototype.drawGpuSubJobLineLabel = function(gpu, gl, renderer, scre
pp = renderer.project2(job.center2, renderer.camera.mvp, renderer.cameraPosition, true);
}

var targetSize = job.labelSize * 0.5 * 0.5; //last 0.5 part is to make it compatible to 2D text
var sizeFactor = renderer.camera.scaleFactor2(pp[3])*0.5*renderer.curSize[1];
var targetSize = job.labelSize * 0.5;
var sizeFactor = renderer.camera.scaleFactor2(pp[3])*0.5*renderer.curSize[1]*(renderer.curSize[0]/renderer.curSize[1]);
var labelPoints = job.labelPoints;
var labelIndex = job.labelIndex;
var labelMorph = 0;
Expand Down
20 changes: 11 additions & 9 deletions src/core/renderer/renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ Renderer.prototype.getScreenRay = function(screenX, screenY) {

this.camera.dirty = true; //???? why is projection matrix distored so I have to refresh

//conver screen coords
//convert screen coords
var x = (2.0 * screenX) / this.curSize[0] - 1.0;
var y = 1.0 - (2.0 * screenY) / this.curSize[1];

Expand Down Expand Up @@ -527,16 +527,17 @@ Renderer.prototype.getScreenRay = function(screenX, screenY) {
Renderer.prototype.hitTestGeoLayers = function(screenX, screenY, secondTexture) {
var gl = this.gpu.gl;

//conver screen coords to texture coords
if (gl.checkFramebufferStatus(gl.FRAMEBUFFER) != gl.FRAMEBUFFER_COMPLETE) {
return [false, 0,0,0,0];
}
//probably not needed
//if (gl.checkFramebufferStatus(gl.FRAMEBUFFER) != gl.FRAMEBUFFER_COMPLETE) {
// return [false, 0,0,0,0];
//}

var surfaceHit = false, pixel;

if (screenX >= 0 && screenX < this.curSize[0] &&
screenY >= 0 && screenY < this.curSize[1]) {

//convert screen coords to texture coords
var x = 0, y = 0;

//get screen coords
Expand Down Expand Up @@ -674,11 +675,12 @@ Renderer.prototype.hitTest = function(screenX, screenY) {
var screenRay = this.getScreenRay(screenX, screenY);
var cameraPos = this.camera.getPosition();

//conver screen coords to texture coords
if (gl.checkFramebufferStatus(gl.FRAMEBUFFER) != gl.FRAMEBUFFER_COMPLETE) {
return [0, 0, 0, null, screenRay, Number.MAX_VALUE, cameraPos];
}
//probably not needed
//if (gl.checkFramebufferStatus(gl.FRAMEBUFFER) != gl.FRAMEBUFFER_COMPLETE) {
// return [0, 0, 0, null, screenRay, Number.MAX_VALUE, cameraPos];
//}

//convert screen coords to texture coords
var x = 0, y = 0;

//get screen coords
Expand Down
4 changes: 2 additions & 2 deletions src/core/renderer/rmap.js
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ RendererRMap.prototype.addLineLabel = function(subjob, checkDepthMap) {
var index = 0, pindex = 0;
var margin = job.noOverlap ? job.noOverlap[0] : 1;

var targetSize = job.labelSize * 0.5 * 0.5;
var sizeFactor = renderer.camera.scaleFactor2(subjob[5][3])*0.5*renderer.curSize[1];
var targetSize = job.labelSize * 0.5;
var sizeFactor = renderer.camera.scaleFactor2(subjob[5][3])*0.5*renderer.curSize[1]*(renderer.curSize[0]/renderer.curSize[1]);
var pointsIndex = subjob[9];
var labelPoints = job.labelPoints;
var labelIndex = job.labelIndex;
Expand Down

0 comments on commit 8fdd34b

Please sign in to comment.