Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs about duration of SDK initialization #23

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

varsill
Copy link
Collaborator

@varsill varsill commented Nov 29, 2024

This PR:

  • moves Agora SDK initialization from handle_setup to handle_playing
  • renames modules in lib/ according to the assumed naming convention in the membrane plugins
  • adds logs about the duration of Agora SDK initialization

Copy link
Collaborator

@nickdichev-firework nickdichev-firework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-02 at 4 34 10 PM

Sweet, I've also seen that there is some data about the sdk initialization that we can get from the agora side. I wonder if we would be able to see anything interesting

@varsill
Copy link
Collaborator Author

varsill commented Dec 5, 2024

@nickdichev-firework Definitely we should be able to find something interesting! We would need to find those logs for the channel which was used during the session for which startup took that long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants