Remove unnecessary comments

membraneframework · Mar 27, 2024 · 93de2fc · 93de2fc
1 parent 95b045f
commit 93de2fc
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 8 deletions.
diff --git a/lib/membrane/core/bin.ex b/lib/membrane/core/bin.ex
@@ -70,8 +70,6 @@ defmodule Membrane.Core.Bin do
 
     if node do
       result = :rpc.call(node, GenServer, :start, [__MODULE__, options])
-
-      # TODO: use an atomic way of linking once https://github.com/erlang/otp/issues/6375 is solved
       with {:start_link, {:ok, pid}} <- {method, result}, do: Process.link(pid)
       result
     else

diff --git a/lib/membrane/core/element.ex b/lib/membrane/core/element.ex
@@ -86,8 +86,6 @@ defmodule Membrane.Core.Element do
     # rpc if necessary
     if node do
       result = :rpc.call(node, GenServer, :start, [__MODULE__, options])
-
-      # TODO: use an atomic way of linking once https://github.com/erlang/otp/issues/6375 is solved
       with {:start_link, {:ok, pid}} <- {method, result}, do: Process.link(pid)
       result
     else

diff --git a/lib/membrane/core/element/action_handler.ex b/lib/membrane/core/element/action_handler.ex
@@ -348,7 +348,6 @@ defmodule Membrane.Core.Element.ActionHandler do
            stalker_metrics: stalker_metrics
          }
          when stream_format != nil <- pad_data do
-      # todo: move this function to one of the controllers, to avoid redundant PadModet.get_data in the function below
       state = DemandController.decrease_demand_by_outgoing_buffers(pad_ref, buffers, state)
       :atomics.add(stalker_metrics.total_buffers, 1, length(buffers))
       Message.send(pid, :buffer, buffers, for_pad: other_ref)
@@ -422,7 +421,6 @@ defmodule Membrane.Core.Element.ActionHandler do
   defp delay_supplying_demand(pad_ref, size, state) do
     with %{direction: :input, flow_control: :manual} <-
            PadModel.get_data!(state, pad_ref) do
-      # todo: get_data! above could be eradicated
       state = ManualFlowController.update_demand(pad_ref, size, state)
       ManualFlowController.delay_supplying_demand(pad_ref, state)
     else
@@ -444,7 +442,6 @@ defmodule Membrane.Core.Element.ActionHandler do
        when type in [:source, :filter, :endpoint] do
     with %{direction: :output, flow_control: :manual} <-
            PadModel.get_data!(state, pad_ref) do
-      # todo: get_data! above could be eradicated
       ManualFlowController.delay_redemand(pad_ref, state)
     else
       %{direction: :input} ->

diff --git a/lib/membrane/core/element/buffer_controller.ex b/lib/membrane/core/element/buffer_controller.ex
@@ -63,7 +63,6 @@ defmodule Membrane.Core.Element.BufferController do
     end
   end
 
-  # todo: move it to the flow controllers?
   @spec do_handle_ingoing_buffers(
           Pad.ref(),
           PadModel.pad_data(),