Ensure handle_demand busy wait infinite loop doesn't occur & deprecate message_child #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
changed the title
FelonEkonom
changed the title
…mands loop message at the time
FelonEkonom
force-pushed
the
tests-upgrade
branch
from
3146155 to
150069c
Compare
mat-hek
reviewed
Mar 19, 2024
|
|
||
| pipeline = Testing.Pipeline.start_link_supervised!(spec: spec) | ||
|
|
||
| Process.sleep(1_000) |
There was a problem hiding this comment.
you can assert_start_of_stream on each sink instead
|
|
||
| Process.sleep(1_000) | ||
|
|
||
| for _i <- 1..(auto_demand_size + 5) do |
There was a problem hiding this comment.
To ensure, that this line
will be executed
There was a problem hiding this comment.
Now I think, that it would be good to have auto_demand_size < delayed_demand_loop_counter_limit, to ensure, that counter won't reset after reaching linked code. I will change this
There was a problem hiding this comment.
so let’s change the naming or add a comment indicating it’s to exceed the loop counter limit
FelonEkonom
force-pushed
the
tests-upgrade
branch
from
8769ebf to
bd5f8f3
Compare
mat-hek
approved these changes
Mar 20, 2024
Comment on lines
57
to
59
| # auto_demand_size is smaller than delayed_demands_loop_counter_limit to ensure, that counter | ||
| # doesn't reset after calling handle_demand caused by reading positive atomic demand value | ||
| # during the snaphsot |
There was a problem hiding this comment.
Suggested change
| # auto_demand_size is smaller than delayed_demands_loop_counter_limit to ensure, that counter | |
| # doesn't reset after calling handle_demand caused by reading positive atomic demand value | |
| # during the snaphsot | |
| # auto_demand_size is smaller than delayed_demands_loop_counter_limit, to ensure that | |
| # after calling handle_demand and making a snapshot, the atomic demand value is still positive | |
| # and the counter is not reset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #769
Related to #706