Implement handle_spec_setup_completed and handle_spec_playing. Release v1.1.0-rc1. #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
added
no-changelog
FelonEkonom
force-pushed
the
handle_spec_playing
branch
from
790948f to
664d474
Compare
FelonEkonom
changed the title
FelonEkonom
changed the title
mat-hek
requested changes
May 20, 2024
Comment on lines
324
to
325
| MapSet.to_list(spec_data.children_names) | ||
| |> StartupUtils.exec_handle_spec_setup_completed(state) |
There was a problem hiding this comment.
The problem here is that the children_names can be empty, and we call handle_spec_started with an empty list. This makes me lean towards having handle_child_setup and handle_child_playing instead.
mat-hek
reviewed
May 27, 2024
lib/membrane/child_entry.ex
Outdated
| @@ -38,6 +41,7 @@ defmodule Membrane.ChildEntry do | |||
| :group, | |||
| initialized?: false, | |||
| ready?: false, | |||
| terminating?: false | |||
| terminating?: false, | |||
| playback: :stopped | |||
There was a problem hiding this comment.
Before my changes we have been sending :play to each child between 1 and 2 times. This field allows me distinct, if I have already done it, because I don't want to execute callback handle_child_playing more than once for a single child
There was a problem hiding this comment.
I think we never send play two times. If we do, it seems like a bug.
mat-hek
approved these changes
May 29, 2024
mat-hek
requested changes
May 29, 2024
lib/membrane/child_entry.ex
Outdated
| @@ -38,6 +41,7 @@ defmodule Membrane.ChildEntry do | |||
| :group, | |||
| initialized?: false, | |||
| ready?: false, | |||
| terminating?: false | |||
| terminating?: false, | |||
| playback: :stopped | |||
There was a problem hiding this comment.
I think we never send play two times. If we do, it seems like a bug.
mat-hek
approved these changes
Jun 3, 2024
lib/membrane/child_entry.ex
Outdated
| @@ -21,7 +21,7 @@ defmodule Membrane.ChildEntry do | |||
| module: module, | |||
| options: struct | nil, | |||
| component_type: :element | :bin, | |||
| playback: Membrane.Playback.t(), | |||
| # playback: Membrane.Playback.t(), | |||
lib/membrane/child_entry.ex
Outdated
| terminating?: false, | ||
| playback: :stopped | ||
| terminating?: false | ||
| # playback: :stopped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #796
Relates to #786