Ensure error logs are always printed #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
added
the
no-changelog
mat-hek
approved these changes
Jun 10, 2024
lib/membrane/core/macros.ex
Outdated
| @@ -0,0 +1,24 @@ | |||
| defmodule Membrane.Core.Macros do | |||
There was a problem hiding this comment.
Suggested change
| defmodule Membrane.Core.Macros do | |
| defmodule Membrane.Core.Utils do |
varsill
requested changes
Jun 10, 2024
lib/membrane/core/element.ex
Outdated
Comment on lines
212
to
214
| Macros.log_on_error do | ||
| do_handle_info(message, state) | ||
| end |
There was a problem hiding this comment.
why Telemetry.report_metric is outside of the Macros.log_on_error?
Co-authored-by: Łukasz Kita <[email protected]>
varsill
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Initially I just thought of adding it only in other processes that can execute users code (just like ResourceGuard, which executes registered user's lambda), but since you have added logging to all GenServers it's even better, as it will be easier for us to debug if we made some mistakes :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.