Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect diamonds #909

Merged
merged 35 commits into from
Dec 23, 2024
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
7263c9a
Write separate module for diamonds detection WiP
FelonEkonom Nov 20, 2024
f4bce2d
Implement parallel diamond detection WiP
FelonEkonom Nov 20, 2024
e9e8c77
Small refactor
FelonEkonom Nov 20, 2024
cabbcfb
Fix bug
FelonEkonom Nov 20, 2024
a58b363
Fix typo
FelonEkonom Nov 21, 2024
5a76b10
Comment out triggering diamond detection in parents
FelonEkonom Nov 21, 2024
0be84b9
Trigger diamon detection between elements WiP
FelonEkonom Nov 21, 2024
58c5384
Trigger diamon detection between elements WiP
FelonEkonom Nov 22, 2024
7b5fdad
Fix typos
FelonEkonom Nov 22, 2024
646898c
wip
FelonEkonom Nov 22, 2024
30b757e
Log diamond wip
FelonEkonom Nov 25, 2024
39030a7
Add test wip
FelonEkonom Nov 26, 2024
a3c6bdd
Add more test cases wip
FelonEkonom Nov 26, 2024
9855e8a
Refactor diamond detection code
FelonEkonom Nov 26, 2024
f5d6941
Remove unused import
FelonEkonom Nov 26, 2024
acbe87d
Improve diamond log message, fix credo
FelonEkonom Nov 27, 2024
f02d57e
Remove leftover files
FelonEkonom Nov 27, 2024
2327b24
Merge remote-tracking branch 'origin/master' into pull-diamonds
FelonEkonom Nov 27, 2024
35cf655
Update changelog
FelonEkonom Nov 27, 2024
c8b586a
Remove leftovers
FelonEkonom Nov 27, 2024
97d15cf
Fix Connector test
FelonEkonom Nov 27, 2024
6314803
Fix typo in the comment
FelonEkonom Nov 27, 2024
1f94101
Refactor State due to CR
FelonEkonom Dec 4, 2024
090488a
Refactor diamond detection messages
FelonEkonom Dec 4, 2024
1d003ba
stop creating serialized component path every time
FelonEkonom Dec 4, 2024
501aeee
Write some comments describing how the diamond detection mechanism works
FelonEkonom Dec 5, 2024
07fcfd1
Move the comments within the file
FelonEkonom Dec 5, 2024
cc9039d
Fix typos in the algorithm description
FelonEkonom Dec 6, 2024
d364df9
Implement CR suggestions WiP
FelonEkonom Dec 16, 2024
c158ee8
Implement CR suggestions WiP
FelonEkonom Dec 16, 2024
8df71f8
Further refactor
FelonEkonom Dec 16, 2024
0bff060
Algorithm description refactor
FelonEkonom Dec 16, 2024
2dff094
Implement suggestions from CR
FelonEkonom Dec 17, 2024
0db0f3f
Refactor algortithm description
FelonEkonom Dec 23, 2024
b70fa7b
Merge remote-tracking branch 'origin/master' into pull-diamonds
FelonEkonom Dec 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Connector test
FelonEkonom committed Nov 27, 2024
commit 97d15cf122ab2b7f3e6fd3b1b3452e5e09f44f54
2 changes: 2 additions & 0 deletions test/membrane/integration/connector_test.exs
Original file line number Diff line number Diff line change
@@ -34,6 +34,8 @@ defmodule Membrane.Integration.ConnectorTest do
})
)

assert_child_playing(pipeline, :source)

data = generate_data(100, [:stream_format, :buffer, :event])

data