Merge pull request #25 from membraneframework/fix/common-file-impl-co…

…nfig

Fix missing default value for `:file_impl` config

README.md

@@ -15,7 +15,7 @@ The package can be installed by adding `membrane_file_plugin` to your list of de
 ```elixir
 def deps do
   [
-    {:membrane_file_plugin, "~> 0.11.0"}
+    {:membrane_file_plugin, "~> 0.11.1"}
   ]
 end
 ```

lib/membrane_file/common_file_behaviour.ex

@@ -4,6 +4,15 @@ defmodule Membrane.File.CommonFileBehaviour do
   alias Membrane.Buffer
   alias Membrane.File.SeekEvent
 
+  @common_file_impl Application.compile_env(
+                      :membrane_file_plugin,
+                      :file_impl,
+                      Membrane.File.CommonFile
+                    )
+
+  @spec get_impl() :: module()
+  def get_impl(), do: @common_file_impl
+
   @type posix_error_t :: {:error, File.posix()}
   @type generic_error_t :: {:error, File.posix() | :badarg | :terminated}
 

lib/membrane_file/sink.ex

@@ -12,7 +12,7 @@ defmodule Membrane.File.Sink do
 
   alias Membrane.File.SeekEvent
 
-  @common_file Application.compile_env(:membrane_file_plugin, :file_impl)
+  @common_file Membrane.File.CommonFileBehaviour.get_impl()
 
   def_options location: [
                 spec: Path.t(),

lib/membrane_file/sink_multi.ex

@@ -11,7 +11,7 @@ defmodule Membrane.File.Sink.Multi do
   """
   use Membrane.Sink
 
-  @common_file Application.compile_env(:membrane_file_plugin, :file_impl)
+  @common_file Membrane.File.CommonFileBehaviour.get_impl()
 
   def_options location: [
                 spec: Path.t(),

lib/membrane_file/source.ex

@@ -7,7 +7,7 @@ defmodule Membrane.File.Source do
 
   alias Membrane.{Buffer, RemoteStream}
 
-  @common_file Application.compile_env(:membrane_file_plugin, :file_impl)
+  @common_file Membrane.File.CommonFileBehaviour.get_impl()
 
   def_options location: [
                 spec: Path.t(),

mix.exs

@@ -1,7 +1,7 @@
 defmodule Membrane.File.Plugin.Mixfile do
   use Mix.Project
 
-  @version "0.11.0"
+  @version "0.11.1"
   @github_url "https://github.com/membraneframework/membrane_file_plugin"
 
   def project do
@@ -49,15 +49,13 @@ defmodule Membrane.File.Plugin.Mixfile do
 
   defp dialyzer() do
     opts = [
-      plt_local_path: "priv/plts",
       flags: [:error_handling]
     ]
 
     if System.get_env("CI") == "true" do
-      # Store core PLTs in cacheable directory for CI
-      # For development it's better to stick to default, $MIX_HOME based path
-      # to allow sharing core PLTs between projects
-      [plt_core_path: "priv/plts"] ++ opts
+      # Store PLTs in a directory cacheable on CI
+      File.mkdir_p!(Path.join([__DIR__, "priv", "plts"]))
+      [plt_local_path: "priv/plts", plt_core_path: "priv/plts"] ++ opts
     else
       opts
     end
@@ -67,7 +65,6 @@ defmodule Membrane.File.Plugin.Mixfile do
     [
       maintainers: ["Membrane Team"],
       licenses: ["Apache-2.0"],
-      files: ["lib", ".formatter.exs", "mix.exs", "README*", "LICENSE*"],
       links: %{
         "GitHub" => @github_url,
         "Membrane Framework Homepage" => "https://membraneframework.org"