Skip to content

Commit

Permalink
Fix dirty NIF scheduler configuration for RTMP.Sink (#86)
Browse files Browse the repository at this point in the history
* Make sure try_connect/1 is scheduled on a dirty scheduler. Fix a dirty scheduler configuration for write_video_frame/5

* Implement `validate_on_expect_additional_media` for the TestValidator to fix a CI failure
* bump version to v0.22.1
  • Loading branch information
varsill authored Feb 19, 2024
1 parent e1fef39 commit 3bbb0e5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The package can be installed by adding `membrane_rtmp_plugin` to your list of de
```elixir
def deps do
[
{:membrane_rtmp_plugin, "~> 0.22.0"}
{:membrane_rtmp_plugin, "~> 0.22.1"}
]
end
```
Expand Down
2 changes: 1 addition & 1 deletion c_src/membrane_rtmp_plugin/sink/rtmp_sink.spec.exs
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ spec init_audio_stream(state, channels :: int, sample_rate :: int, aac_config ::
spec write_audio_frame(state, frame :: payload, pts :: int64) ::
{:ok :: label, state} | {:error :: label, reason :: string}

dirty :io, write_video_frame: 4, write_audio_frame: 3
dirty :io, write_video_frame: 5, write_audio_frame: 3, try_connect: 1
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
defmodule Membrane.RTMP.Mixfile do
use Mix.Project

@version "0.22.0"
@version "0.22.1"
@github_url "https://github.com/membraneframework/membrane_rtmp_plugin"

def project do
Expand Down
4 changes: 4 additions & 0 deletions test/support/test_validator.ex
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,8 @@ defimpl Membrane.RTMP.MessageValidator, for: Support.TestValidator do

@impl true
def validate_on_meta_data(_impl, _message), do: {:ok, "on meta data success"}

@impl true
def validate_on_expect_additional_media(_impl, _message),
do: {:ok, "on expect additional media success"}
end

0 comments on commit 3bbb0e5

Please sign in to comment.