Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load bar with the same timestamp as the latest bar; #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tzion
Copy link

@Tzion Tzion commented Jan 6, 2022

This can happen when joining data from file and live data
(backfilling). In this case, if the last bar of the file data
is of the same time as the bar in the live data - both of them will
be added.

Detailed example:
File data contains the daily bars of: [21/11/17, 21/11/18]. We're sending request for historical data between the dates: 21/11/17 - 21/11/23, and using backfilling from the file.
When loading the data - the 11/17 and 11/18 will be taken from the file, and since the data point of the 11/18 from the server does not fulfill the condition dt < self.lines.datetime[-1] it will be taken as well.
End result: data contains 2 data points of the 11/18.

This can happen when joining data from file and live data
(backfilling). In this case, if the last bar of the file data
is of the same time as the bar in the live data - both of them will
be added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant