-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create memgraph-lab chart #18
Conversation
tewnut
commented
Apr 29, 2024
- Supported templates: deployment, service, serviceaccount, ingress and hpa.
- Tested with k8s 1.27, memgraph 2.16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great, just two small comments. Good job 🚀
Later we can maybe introduce the Memgraph dependency, so the Memgraph-Lab becomes the both Memgraph and Lab in same deployment. OFC with the option to disable it at the start. But we will probably do that part since it involves upgrading the Memgraph chart.
Can you just update the README for available charts in this PR: https://github.com/memgraph/helm-charts?tab=readme-ov-file#available-charts?
Yes, certainly I will update the readme very soon. Stacking all components into one chart is a popular design. At the same time keeping them separate (and highly independent of each other) has the beauty of its own. In my opinion, separating them is more beneficial, it may encourage community to further develop other UI (among other) components, which will boost adoption of Memgraph as a whole. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀