Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at how to contribute blog posts #92

Merged
merged 1 commit into from
Oct 2, 2019
Merged

First pass at how to contribute blog posts #92

merged 1 commit into from
Oct 2, 2019

Conversation

svpernova09
Copy link
Member

This is regarding #63

@svpernova09 svpernova09 requested a review from tbrownaw October 2, 2019 00:30
@unstablereality
Copy link
Member

This guy is terrible and shouldn't be allowed to write code

@svpernova09
Copy link
Member Author

This guy is terrible and shouldn't be allowed to write code

You're not wrong.

@tbrownaw
Copy link
Contributor

tbrownaw commented Oct 2, 2019

This doesn't say much about what front matter is appropriate.

tbrownaw
tbrownaw requested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@tbrownaw tbrownaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain more about what's appropriate?

@svpernova09
Copy link
Member Author

Users should copy front matter from other files (i'm live coding this please have mercy)

tbrownaw
tbrownaw approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@tbrownaw tbrownaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fine whatever

@svpernova09 svpernova09 merged commit 930a6d7 into master Oct 2, 2019
@svpernova09 svpernova09 deleted the 63-wrote-some-words branch October 2, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrownaw tbrownaw tbrownaw approved these changes

Assignees

@tbrownaw tbrownaw

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svpernova09 @unstablereality @tbrownaw