Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad WebSocket URL in CrawlWatcher #1053

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix bad WebSocket URL in CrawlWatcher #1053

merged 2 commits into from
Jan 28, 2025

Conversation

ProfHercules
Copy link
Contributor

Fixed CrawlWatcher creating WebSocket using standard http url from base app.

@ProfHercules
fix: bad websocket url in crawl watcher
f6c5fdd 
Fixed CrawlWatcher creating WebSocket using standard http url from base app.
mogery
mogery approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@mogery mogery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ProfHercules
Copy link
Contributor Author

Could improve this by using a regex to replace either http or https with ws (only at the start of the string).

mogery
mogery approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@mogery mogery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mogery mogery merged commit b8c4e19 into mendableai:main Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogery mogery mogery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProfHercules @mogery