linter used

mendixlabs · Nov 12, 2022 · f349a2c · f349a2c
1 parent 1976978
commit f349a2c
Show file tree

Hide file tree

Showing 2 changed files with 67 additions and 48 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,5 +1,10 @@
 const base = require("@mendix/pluggable-widgets-tools/configs/eslint.ts.base.json");
 
 module.exports = {
-    ...base
+    ...base,
+    rules: {
+        "no-unused-vars": "off",
+        "@typescript-eslint/no-unused-vars" : "off",
+        'max-len': ["error", { "code": 500 }]
+    }
 };
diff --git a/src/TabPageSelector.tsx b/src/TabPageSelector.tsx
@@ -3,67 +3,81 @@ import { Big } from "big.js";
 import { TabPageSelectorContainerProps } from "../typings/TabPageSelectorProps";
 
 export default class TabPageSelector extends Component<TabPageSelectorContainerProps> {
-    render(): ReactNode {        
-        if(this.props.paneIndexByAttr === undefined)
-        {
+    render(): ReactNode {
+        if (this.props.paneIndexByAttr === undefined) {
             console.error("Tab page selector not specified. Please specify the attribute to determine tab pane index.");
             return;
-        }    
-        if(this.props.targetTabCtrl === undefined || this.props.targetTabCtrl.trim() == '')
-        {
+        }
+        if (this.props.targetTabCtrl === undefined || this.props.targetTabCtrl.trim() === "") {
             console.error("Target tab container name not specified. Please specify the target tab container name.");
             return;
-        }      
+        }
         return "";
     }
     componentDidMount(): void {
-        let div = document.getElementsByClassName("mx-name-" + this.props.targetTabCtrl);
-        if(div.length > 0 && div.item(0) != null)
-        {
-            let li =div.item(0)!.querySelectorAll('ul > li');
-            if(li == null)
-            {
-                console.error("Unable find tab pane index by specified index.");
+        const div = this.getTargetDiv(this.props.targetTabCtrl);
+        if (div != null) {
+            const li = div.querySelectorAll("ul > li");
+            if (li == null) {
+                console.error("Unable find tab pages");
                 return;
-            }            
-            li.forEach(
-                 (currentValue, _currentIndex, _listObj) => {
-                    currentValue.addEventListener("click", () => {
-                        this.props.paneIndexByAttr?.setValue(Big(_currentIndex+1));
-                    }, false);
-                },
-                this
-            );
-        }
-        else
-        {
-            console.error("Tab container DOM element not found. Please check provided taget tab container name.");
-            return;
+            }
+            li.forEach((currentValue, _currentIndex, _listObj) => {
+                currentValue.addEventListener(
+                    "click",
+                    () => {
+                        this.props.paneIndexByAttr?.setValue(Big(_currentIndex + 1));
+                    },
+                    false
+                );
+            }, this);
+        } else {
+            throw new Error("Unable to find target Tab Container. Check above error logs for more info.");
         }
     }
-    componentDidUpdate(_prevProps: Readonly<TabPageSelectorContainerProps>, _prevState: Readonly<{}>, _snapshot?: any): void {
-        if(this.props.paneIndexByAttr!.value === undefined)
-        {
+    componentDidUpdate(
+        _prevProps: Readonly<TabPageSelectorContainerProps>,
+        _prevState: Readonly<{}>,
+        // eslint-disable-next-line  @typescript-eslint/no-explicit-any
+        _snapshot?: any
+    ): void {
+        if (this.props.paneIndexByAttr.value === undefined) {
             console.error("Tab page selector not specified. Please specify the attribute to determine tab pane index.");
             return;
-        }  
-        if(this.props.paneIndexByAttr!.value.lte(Big(0)))
-        {
+        }
+        if (this.props.paneIndexByAttr.value.lte(Big(0))) {
             console.error("Tab page selector number cannot be less than or equal to zero.");
             return;
         }
-        let div = document.getElementsByClassName("mx-name-" + this.props.targetTabCtrl);
-        if(div.length > 0 && div.item(0) != null)
-        {
-            let liList =div.item(0)!.querySelectorAll('ul > li');
-            let li: HTMLElement = liList.item(parseInt(this.props.paneIndexByAttr!.value!.toString()!)-1) as HTMLElement;
-            if(li == null)
-            {
-                console.debug("Determined tab page index is: " + this.props.paneIndexByAttr!.value);
-                console.error("Unable find tab page index by specified index.");
-            }          
-            if(li!=null)
-                li.click()
-        }        
+        const div = this.getTargetDiv(this.props.targetTabCtrl);
+        if (div != null) {
+            const liList = div.querySelectorAll("ul > li");
+            const li: HTMLElement = liList.item(
+                parseInt(this.props.paneIndexByAttr.value.toString(), 10) - 1
+            ) as HTMLElement;
+            if (li == null) {
+                console.debug("Determined tab page number is: " + this.props.paneIndexByAttr.value);
+                console.error("Unable find tab page by specified number.");
+            }
+            if (li != null) {
+                li.click();
+            }
+        } else {
+            throw new Error("Unable to find target Tab Container. Check above error logs for more info.");
+        }
+    }
+    getTargetDiv(targetTabCtrl: string): Element | null {
+        const divList = document.getElementsByClassName("mx-name-" + targetTabCtrl);
+        if (divList.length > 0) {
+            const div = divList.item(0);
+            if (div != null) {
+                return div;
+            } else {
+                console.error("Tab container DOM element found, but unable to get it's referance.");
+            }
+        } else {
+            console.error("Tab container DOM element not found. Please check provided taget tab container name.");
+        }
+        return null;
     }
 }