fix: Algolia search works again #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://meshcloud-docs-dev-pr-682.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ckp6re41tcps738t4kjg. |
tfelix
approved these changes
Oct 20, 2023
| @@ -6,9 +6,9 @@ | |||
| "scripts": { | |||
| "examples": "docusaurus-examples", | |||
| "start": "docusaurus-start", | |||
| "build:master": "DOCSEARCH_INDEXNAME='meshcloud' DOCSEARCH_APIKEY='1b6387d9fcda3cba4cdb3ffb68cde260' docusaurus-build", | |||
| "build:master": "DOCSEARCH_INDEXNAME='meshcloud' DOCSEARCH_APIKEY='aa3b874dff5c832fe2e3ed42a8062160' DOCSEARCH_APP_ID='LDDGX81P02' docusaurus-build", | |||
There was a problem hiding this comment.
d: I hope this APIKEY is not sensitive so its okay to have it in the public repo? Not that someone can extract this key and post a own, modified search result to the service? Not sure how it works. I thought during build time it generates an index and transmits to their server? Then to have those keys here I guess could be problematic?
There was a problem hiding this comment.
The key is just for querying in frontend and is safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All in all this seems to work now. You can run
yarn build:masterlocally and serve the build and it will work :-)Demo: https://jmp.sh/erIJKzE9