Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5.17 #1058

Merged
merged 3 commits into from
Jan 16, 2025

Bump version

e9464e0
Select commit
Loading
Failed to load commit list.
Merged

2.5.17 #1058

Bump version
e9464e0
Select commit
Loading
Failed to load commit list.
Xcode Cloud / MeshtasticApple | Merge to Main | Archive - macOS succeeded Jan 16, 2025 in 11m 15s

19 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 19

Details

19 Warnings

Details

  Meshtastic/Views/Messages/Messages.swift:73
      Immutable value 'channelId' was never used; consider replacing with '_' or removing it
  Meshtastic/Helpers/Mqtt/MqttClientProxyManager.swift:46
      Variable 'username' was never mutated; consider changing to 'let' constant
  Meshtastic/AppIntents/ShutDownNodeIntent.swift:17
      'requestConfirmation(result:confirmationActionName:showPrompt:)' is deprecated: Please use requestConfirmation(conditions:actionName:dialog:) or requestConfirmation(conditions:actionName:dialog:showDialogAsPrompt:content:)
  Meshtastic/AppIntents/FactoryResetNodeIntent.swift:17
      'requestConfirmation(result:confirmationActionName:showPrompt:)' is deprecated: Please use requestConfirmation(conditions:actionName:dialog:) or requestConfirmation(conditions:actionName:dialog:showDialogAsPrompt:content:)
  Meshtastic/MeshtasticAppDelegate.swift:67
      Initialization of immutable value 'tapbackResponse' was never used; consider replacing with assignment to '_' or removing it
  Meshtastic/Views/Settings/Config/Module/MQTTConfig.swift:360
      Initialization of immutable value 'cc' was never used; consider replacing with assignment to '_' or removing it
  Meshtastic/Helpers/LocationsHandler.swift:60
      'isStationary' is deprecated: renamed to 'stationary'
  Meshtastic/Views/Messages/Messages.swift:73
      Immutable value 'messageId' was never used; consider replacing with '_' or removing it
  Meshtastic/AppIntents/RestartNodeIntent.swift:18
      'requestConfirmation(result:confirmationActionName:showPrompt:)' is deprecated: Please use requestConfirmation(conditions:actionName:dialog:) or requestConfirmation(conditions:actionName:dialog:showDialogAsPrompt:content:)
  Meshtastic/Views/Messages/Messages.swift:75
      Immutable value 'userNum' was never used; consider replacing with '_' or removing it
  Meshtastic/Views/Settings/Config/Module/MQTTConfig.swift:278
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
   command not found - See https://github.com/realm/SwiftLint#installation for installation instructions.
  Meshtastic/Helpers/Mqtt/MqttClientProxyManager.swift:47
      Variable 'password' was never mutated; consider changing to 'let' constant
  Meshtastic/Views/Settings/Config/Module/MQTTConfig.swift:281
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  Meshtastic/MeshtasticAppDelegate.swift:53
      Initialization of immutable value 'tapbackResponse' was never used; consider replacing with assignment to '_' or removing it
  Meshtastic/Views/Settings/Config/Module/MQTTConfig.swift:284
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  Meshtastic/MeshtasticAppDelegate.swift:82
      Initialization of immutable value 'tapbackResponse' was never used; consider replacing with assignment to '_' or removing it
  Meshtastic/Views/Settings/AppLog.swift:273
      Extension declares a conformance of imported type 'OSLogEntry' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'OSLog' introduce this conformance in the future
  Meshtastic/Views/Messages/Messages.swift:75
      Immutable value 'messageId' was never used; consider replacing with '_' or removing it