Add node name below traceroute node circles #966
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you attach a screenshot for reference showing how this renders in the UI? |
powersjcb
reviewed
Oct 20, 2024
| @@ -869,6 +869,7 @@ class BLEManager: NSObject, CBPeripheralDelegate, MqttClientProxyManagerDelegate | |||
| traceRoute?.hasPositions = true | |||
| } | |||
| } | |||
| traceRouteHop.name = hopNode?.user?.longName ?? "Unknown" | |||
There was a problem hiding this comment.
Is this overriding an existing traceRouteHop.name value or is this populating an empty field?
There was a problem hiding this comment.
The field is currently not used.
I was a bit torn with this one. Without a data model update, we have one name. That could be used for the short name, to correct the name inside the circle. Otherwise, there is this option, to add the long name under the circle.
There was a problem hiding this comment.
Suggested change
| traceRouteHop.name = hopNode?.user?.longName ?? "Unknown" | |
| traceRouteHop.name = hopNode?.user?.longName ?? Constants.unknownTracerouteHopName |
and
private extension BLEManager {
enum Constants {
static let unknownTracerouteHopName = String(localized: "Unknown", comment: "Label: Unknown trace route node name")
}
}
|
Here's an example. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
4np
reviewed
Feb 19, 2025
| @@ -869,6 +869,7 @@ class BLEManager: NSObject, CBPeripheralDelegate, MqttClientProxyManagerDelegate | |||
| traceRoute?.hasPositions = true | |||
| } | |||
| } | |||
| traceRouteHop.name = hopNode?.user?.longName ?? "Unknown" | |||
There was a problem hiding this comment.
Suggested change
| traceRouteHop.name = hopNode?.user?.longName ?? "Unknown" | |
| traceRouteHop.name = hopNode?.user?.longName ?? Constants.unknownTracerouteHopName |
and
private extension BLEManager {
enum Constants {
static let unknownTracerouteHopName = String(localized: "Unknown", comment: "Label: Unknown trace route node name")
}
}| @@ -898,6 +899,7 @@ class BLEManager: NSObject, CBPeripheralDelegate, MqttClientProxyManagerDelegate | |||
| traceRoute?.hasPositions = true | |||
| } | |||
| } | |||
| traceRouteHop.name = hopNode?.user?.longName ?? "Unknown" | |||
There was a problem hiding this comment.
Suggested change
| traceRouteHop.name = hopNode?.user?.longName ?? "Unknown" | |
| traceRouteHop.name = hopNode?.user?.longName ?? Constants.unknownTracerouteHopName |
| Text(String(hops[i].name ?? "Unknown")) | ||
| .font(idiom == .phone ? .caption2 : .headline) | ||
| .allowsTightening(true) | ||
| .fontWeight(.semibold) | ||
| Text("\(String(format: "%.2f", hops[i].snr)) dB") |
There was a problem hiding this comment.
Suggested change
| Text("\(String(format: "%.2f", hops[i].snr)) dB") | |
| Text("\(hops[i].snr.formatted(.number.rounded(rule: .toNearestOrAwayFromZero))) dB") |
| @@ -225,6 +225,10 @@ struct TraceRouteLog: View { | |||
| VStack { | |||
| let nodeColor = UIColor(hex: UInt32(truncatingIfNeeded: hops[i].num)) | |||
| CircleText(text: String(hops[i].num.toHex().suffix(4)), color: Color(nodeColor), circleSize: idiom == .phone ? 70 : 125) | |||
| Text(String(hops[i].name ?? "Unknown")) | |||
There was a problem hiding this comment.
Unknown is not localized:
Suggested change
| Text(String(hops[i].name ?? "Unknown")) | |
| Text(String(hops[i].name ?? "Unknown")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Proposing adding the long node name below the node circles in the tracroute view. This change adds
some missing traceRouteHop name assignments and then adds the name string below the node
circle and above the snr string.
Why did it change?
Currently neither the node's short nor long name are part of circular traceroute view. This leverages the
fact that the name is already available to the view and adds it in the same way other node circle names
are represented elsewhere in the app.
How is this tested?
Ran various traceroute iterations and saw that the name was being shown under the circles in the circular
traceroute display.
Screenshots/Videos (when applicable)
Checklist