Oem logo #5939
Merged
Oem logo #5939
+78
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
requested review from
tropho23,
jp-bennett,
thebentern and
todd-herbert
|
Please don't trunk fmt userPrefs.json - this will break the file. |
There was a problem hiding this comment.
Seems all fine when tested on T-Beam v1.2.
Not a result of this PR, but haven't been able to build it for Wireless Paper just yet; getting some odd toolchain errors. Wondering if the OEM image data define is long enough to upset Win10. Gonna give it a go in WSL just now.
todd-herbert
approved these changes
Jan 27, 2025
thebentern
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes USERPREFS_SPLASH_TITLE in favor of a free text on the secondary logo