fix: TCXO_OPTIONAL featuring SenseCAP Indicator (V1/V2) #5948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro TCXO_OPTIONAL that is supposed to support run-time evaluation for SX1262 XTAL/TCXO seems broken, it leads to compiler errors when using it. Also the variable tcxoVoltage in main.cpp is set but not used anywhere.
Then there's the issue that SX1262Interface reports
SX126x init result -707
but continues without returning an error.This PR fixes the TCXO_OPTIONAL usage and simplifies the code by:
res == RADIOLIB_ERR_SPI_CMD_FAILED
to return init() with an error.Note: I'd rather like to see using
res != RADIOLIB_ERR_NONE
here to leave init() whenever any error occurs, but don't know the impact and can't test with all possible devices...Tested OK with SenseCAP Indicator V1/V2 and promicro XTAL.