Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Updated implementation of node serial based on latest main branch #119

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

benbrown
Copy link
Contributor

@benbrown benbrown commented Nov 22, 2024

This applies changes from #115 and #117 to the node serial adapter found in the serial branch. This PR is targeted to the MAIN branch, and should have all the latest changes.

This should fix issues where the adapter would go dark after 15 minutes, and also provide more insightful logging from the device when using the node adapter.

TODO:

  • Validate this in the web client
  • Make sure bundling works for web and node

@benbrown
Copy link
Contributor Author

I was able to update the Meshtastic web client to use this version of the library. However, it involved a bit of trial and error, and eventually required me to use some bundler magic to zero out the node-specific dependencies so the final web package would build. Great! Solved for Meshtastic/web.

However, this won't help the average Javascript programmer who wants to use Meshtastic directly in the browser and doesn't want to have build steps like this. I assume that meshtastic/web is not the only consumer of meshtastic/js. Am I wrong?

So this makes me wonder:

  • IS THERE a way to the node/serial functionality work while not polluting the package with browser-incompatible stuff
  • IF NOT, should we create a meshtastic/nodejs package that consumes meshtastic/js and adds the serial layer on top?

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant