Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow request-telemetry to illicit LocalStats response #707

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

thebentern
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.29%. Comparing base (4c7ac60) to head (b180b6f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/mesh_interface.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
- Coverage   60.33%   60.29%   -0.04%     
==========================================
  Files          24       24              
  Lines        3814     3816       +2     
==========================================
  Hits         2301     2301              
- Misses       1513     1515       +2     
Flag Coverage Δ
unittests 60.29% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ianmcorvidae
Copy link
Contributor

LGTM. I'm guessing this is a local-only request, or does this work over the mesh? Either way this seems good though, no real need to prevent people trying it in the CLI, haha.

@ianmcorvidae ianmcorvidae merged commit 6243965 into master Nov 24, 2024
9 of 11 checks passed
@thebentern thebentern deleted the request-localstats branch November 24, 2024 19:44
@thebentern
Copy link
Contributor Author

LGTM. I'm guessing this is a local-only request, or does this work over the mesh? Either way this seems good though, no real need to prevent people trying it in the CLI, haha.

Previously localstats was PhoneAPI only telemtry variant, but in the upcoming 2.5.14 version, it can be requested even over the lora mesh. It just isn't regularly broadcasted on any sort of interval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants