Add new specific workflow exceptions

Two new specific exceptions have been added, 'ActivityOrRobotAlreadyInstalledException' and 'ActivityOrRobotValidationFailureException' in the workflow services. These exceptions are to be thrown in situations  where an activity or robot is already installed or fails validation. This improves error handling by distinguishing specific scenarios during the API's error handling process.

Signed-off-by: mesilov <[email protected]>

src/Core/ApiLevelErrorHandler.php

@@ -8,14 +8,12 @@
 use Bitrix24\SDK\Core\Exceptions\MethodNotFoundException;
 use Bitrix24\SDK\Core\Exceptions\OperationTimeLimitExceededException;
 use Bitrix24\SDK\Core\Exceptions\QueryLimitExceededException;
+use Bitrix24\SDK\Services\Workflows\Exceptions\ActivityOrRobotAlreadyInstalledException;
+use Bitrix24\SDK\Services\Workflows\Exceptions\ActivityOrRobotValidationFailureException;
 use Psr\Log\LoggerInterface;
 
 /**
  * Handle api-level errors and throw related exception
- *
- * Class ApiLevelErrorHandler
- *
- * @package Bitrix24\SDK\Core
  */
 class ApiLevelErrorHandler
 {
@@ -90,6 +88,10 @@ private function handleError(array $responseBody, ?string $batchCommandId = null
                 throw new MethodNotFoundException(sprintf('api method not found %s %s', $errorDescription, $batchErrorPrefix));
             case 'operation_time_limit':
                 throw new OperationTimeLimitExceededException(sprintf('operation time limit exceeded %s %s', $errorDescription, $batchErrorPrefix));
+            case 'error_activity_already_installed':
+                throw new ActivityOrRobotAlreadyInstalledException(sprintf('%s - %s', $errorCode, $errorDescription));
+            case 'error_activity_validation_failure':
+                throw new ActivityOrRobotValidationFailureException(sprintf('%s - %s', $errorCode, $errorDescription));
             default:
                 throw new BaseException(sprintf('%s - %s %s', $errorCode, $errorDescription, $batchErrorPrefix));
         }

src/Core/Core.php

@@ -108,6 +108,16 @@ public function call(string $apiMethod, array $parameters = []): Response
                     // dispatch event, application listeners update domain url host in accounts repository
                     $this->eventDispatcher->dispatch(new PortalDomainUrlChangedEvent($portalOldDomainUrlHost, $portalNewDomainUrlHost));
                     break;
+                case StatusCodeInterface::STATUS_BAD_REQUEST:
+                    $body = $apiCallResponse->toArray(false);
+                    $this->logger->notice(
+                        'bad request',
+                        [
+                            'body' => $body,
+                        ]
+                    );
+                    $this->apiLevelErrorHandler->handle($body);
+                    break;
                 case StatusCodeInterface::STATUS_UNAUTHORIZED:
                     $body = $apiCallResponse->toArray(false);
                     $this->logger->debug(

src/Services/Workflows/Exceptions/ActivityOrRobotAlreadyInstalledException.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Bitrix24\SDK\Services\Workflows\Exceptions;
+
+use Bitrix24\SDK\Core\Exceptions\InvalidArgumentException;
+
+class ActivityOrRobotAlreadyInstalledException extends InvalidArgumentException
+{
+}

src/Services/Workflows/Exceptions/ActivityOrRobotValidationFailureException.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Bitrix24\SDK\Services\Workflows\Exceptions;
+
+use Bitrix24\SDK\Core\Exceptions\InvalidArgumentException;
+
+class ActivityOrRobotValidationFailureException extends InvalidArgumentException
+{
+}