Define no asm source for libffi meson build #1804
Conversation
releases.json
Outdated
| @@ -3952,4 +3953,4 @@ | |||
| "1.3.3-1" | |||
| ] | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
my editor added a newline at the end of the file
https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
There was a problem hiding this comment.
This is a newline removal and does not belong in this PR.
There was a problem hiding this comment.
Please squash changes into one logical change per commit -- don't make followup commits that back out of changes made in a previous commit.
You can do this with e.g. git commit --amend && git push --force to correct a mistake in the previous commit. See also git rebase -i to re-order and combine commits together via the "fixup" method.
|
any idea on why pipeline fails and sometime it has no problem ? |
The test failure appears to be for previously uncovered CPU architectures -- we very recently added qemu based CI on Alpine, and that's what is failing. Hopefully @xclaesse can look at this, as the author of the libffi wrap. We don't need to block this PR on that pipeline failure. |
releases.json
Outdated
| @@ -3952,4 +3953,4 @@ | |||
| "1.3.3-1" | |||
| ] | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Please squash changes into one logical change per commit -- don't make followup commits that back out of changes made in a previous commit.
You can do this with e.g. git commit --amend && git push --force to correct a mistake in the previous commit. See also git rebase -i to re-order and combine commits together via the "fixup" method.
and updated release for libffi
aaalloc
force-pushed
the
libffi-wasm-no-asm-source
branch
from
3dac422
to
91794a4
Compare
Actually when compiling libffi with wrapdb patch, it gives
and that's normal behavior because there is no sysv.S for wasm32 (https://github.com/libffi/libffi/tree/master/src/wasm32).
Current PR just put empty asm_sources when target is wasm32