-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Exclude ai-navigator-app from the bundle #1655
Conversation
Signed-off-by: Mikołaj Baranowski <[email protected]>
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't think non-airgapped users are using these bundles right? (using kapps artifacts instead of fetching) Juuust checking
(edit) ☝🏻 nvm, just saw https://github.com/mesosphere/kommander-cli/pull/1178 -- we might want to check with support team just in case if customers are using scripts or something and fetching the s3 bundles?
Signed-off-by: Mikołaj Baranowski <[email protected]>
* fix: Exclude ai-navigator-app from the bundle (#1655) Signed-off-by: Mikołaj Baranowski <[email protected]> * chore: Improve wording Co-authored-by: Jabar Asadi <[email protected]> --------- Signed-off-by: Mikołaj Baranowski <[email protected]> Co-authored-by: Jabar Asadi <[email protected]>
What problem does this PR solve?:
Let's skip ai-navigator-app from the bundle.
Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-99372
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist