Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude ai-navigator-app from the bundle #1655

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mikolajb
Copy link
Contributor

@mikolajb mikolajb commented Oct 5, 2023

What problem does this PR solve?:
Let's skip ai-navigator-app from the bundle.

Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-99372

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mikolajb mikolajb self-assigned this Oct 5, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@mikolajb mikolajb added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Oct 5, 2023
Copy link
Contributor

@gracedo gracedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think non-airgapped users are using these bundles right? (using kapps artifacts instead of fetching) Juuust checking

(edit) ☝🏻 nvm, just saw https://github.com/mesosphere/kommander-cli/pull/1178 -- we might want to check with support team just in case if customers are using scripts or something and fetching the s3 bundles?

@mikolajb mikolajb merged commit a7e5a02 into release-2.6 Oct 5, 2023
13 checks passed
@mikolajb mikolajb deleted the mikolajb/exclude-ai-navigator branch October 5, 2023 22:27
mikolajb added a commit that referenced this pull request Oct 6, 2023
mikolajb added a commit that referenced this pull request Oct 6, 2023
* fix: Exclude ai-navigator-app from the bundle (#1655)

Signed-off-by: Mikołaj Baranowski <[email protected]>

* chore: Improve wording

Co-authored-by: Jabar Asadi <[email protected]>

---------

Signed-off-by: Mikołaj Baranowski <[email protected]>
Co-authored-by: Jabar Asadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants