Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bump kube-prometheus-stack to 48.3.2 #1555

Closed
wants to merge 1 commit into from
Closed

feat: Bump kube-prometheus-stack to 48.3.2 #1555

wants to merge 1 commit into from

Conversation

Azhovan
Copy link
Contributor

@Azhovan Azhovan commented Sep 7, 2023 •
edited
Loading

What problem does this PR solve?:
Back port to 2.6
chart changes: mesosphere/charts#1448

Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-98716

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@Azhovan Azhovan self-assigned this Sep 7, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 7, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@Azhovan Azhovan force-pushed the chartbump/kube-prometheus-stack-48.3.2 branch from a4269ec to 2ebbb60 Compare September 7, 2023 12:11
@Azhovan Azhovan force-pushed the chartbump/kube-prometheus-stack-48.3.2 branch from 2ebbb60 to 30be530 Compare September 7, 2023 12:20
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2023
@Azhovan Azhovan added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Sep 7, 2023
@Azhovan Azhovan mentioned this pull request Sep 7, 2023
Closed
2 tasks
@Azhovan Azhovan force-pushed the chartbump/kube-prometheus-stack-48.3.2 branch from 30be530 to 6536e1d Compare September 7, 2023 13:53
@Azhovan Azhovan added services/kube-prometheus-stack open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Sep 7, 2023
gracedo
gracedo reviewed Sep 7, 2023
View reviewed changes
services/kube-prometheus-stack/48.3.2/helmrelease/kube-prometheus-stack.yaml
@@ -11,7 +11,7 @@ spec:
kind: HelmRepository
name: mesosphere.github.io-charts-staging
namespace: kommander-flux
version: 46.8.0
version: 48.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just worried about jumping 2 major versions in a dkp patch version. in the past we have created "release branches" for the helm charts in m/charts but I would have to remember how that process works, it was a little manual and a little risky when publishing the version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this here mesosphere/charts#1449 backporting the fix to the KPS version we released in DKP 2.6.0 -- some more details in the PR description

gracedo
gracedo reviewed Sep 7, 2023
View reviewed changes
services/kube-prometheus-stack/48.3.2/etcd-metrics-proxy.yaml
@@ -9,7 +9,7 @@ spec:
wait: true
interval: 6h
retryInterval: 1m
path: ./services/kube-prometheus-stack/46.8.0/etcd-metrics-proxy
path: ./services/kube-prometheus-stack/48.3.2/etcd-metrics-proxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use 46.8.1 now that it has been published

@Azhovan
Copy link
Contributor Author

Azhovan commented Sep 8, 2023

closed in favor of #1562

@Azhovan Azhovan closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gracedo gracedo gracedo left review comments

@cbuto cbuto Awaiting requested review from cbuto

@palexster palexster Awaiting requested review from palexster

@cwyl02 cwyl02 Awaiting requested review from cwyl02

Assignees

@Azhovan Azhovan

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ready-for-review services/kube-prometheus-stack size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Azhovan @d2iq-mergebot @gracedo