fix: fixes linter to stay on release branch 2.4 #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillt
added
bug
github-actions
bot
added
the
size/XS
|
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
cwyl02
approved these changes
Sep 7, 2023
cbuto
approved these changes
Sep 7, 2023
cbuto
reviewed
Sep 7, 2023
make/pre-commit.mk
Outdated
| @@ -11,4 +11,5 @@ ifeq ($(wildcard $(PRE_COMMIT_CONFIG_FILE)),) | |||
| $(error Cannot find pre-commit config file $(PRE_COMMIT_CONFIG_FILE). Specify the config file via PRE_COMMIT_CONFIG_FILE variable) | |||
| endif | |||
| env SKIP=$(SKIP) pre-commit run -a --show-diff-on-failure --config $(PRE_COMMIT_CONFIG_FILE) | |||
| git fetch origin main && gitlint --ignore-stdin --commits origin/main..HEAD | |||
| git fetch origin release-2.4 && gitlint --ignore-stdin --commits origin/release-2.4..HEAD | |||
|
|
|||
There was a problem hiding this comment.
pre-commit is complaining about this extra line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist