Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove kubernetes-nodes-containerd #1617

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: remove kubernetes-nodes-containerd #1617

merged 1 commit into from
Sep 25, 2023

Conversation

sonofgibs
Copy link
Contributor

What problem does this PR solve?:
kubernetes-nodes-containerd collects esoteric metrics which are not connected to a dashboard or any alerts. No d specific metrics (like memory use, etc) are scraped by the pods job. This PR removes this job

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-98666

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@sonofgibs sonofgibs self-assigned this Sep 22, 2023
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. services/kube-prometheus-stack and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6275906077

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 6269814304: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@sonofgibs sonofgibs requested a review from a team September 22, 2023 15:04
@gracedo gracedo added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Sep 22, 2023
@sonofgibs sonofgibs merged commit f7b7b88 into main Sep 25, 2023
26 checks passed
@sonofgibs sonofgibs deleted the zgibson/D2IQ-98666 branch September 25, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/kube-prometheus-stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants