fix: enable rbac proxy on kube-prometheus-stack node-exporter #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
services/kube-prometheus-stack
size/XS
mesosphere-ci
added
ok-to-test
|
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/mh/kps-node-exporter-enable-rbac-proxy |
Pull Request Test Coverage Report for Build 12120761185Details
💛 - Coveralls |
mhrabovcin
force-pushed
the
mh/kps-node-exporter-enable-rbac-proxy
branch
from
8d2dd71 to
50e075c
Compare
mhrabovcin
added
ready-for-review
auto-backport
backport-to-release-2.13
and removed
do-not-merge/testing
jimmidyson
approved these changes
Dec 2, 2024
mesosphere-ci
pushed a commit
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 2561760)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mhrabovcin
added a commit
that referenced
this pull request
Dec 2, 2024
…2896) fix: enable rbac proxy on kube-prometheus-stack node-exporter (#2895) (cherry picked from commit 2561760) Co-authored-by: Martin Hrabovcin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Re-enable RBAC proxy on
kube-prometheus-stackdeployedprometheus-node-exporter.Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-104587
Special notes for your reviewer:
Tested manually on daily.
Does this PR introduce a user-facing change?:
Checklist