allow user to exclude stats for each tube in metrics #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use case required to avoid an export of stats for each tube. It is needed when there is only interest in common stats and number of tubes can significantly increase metrics size which could helpen with a large number of tubes (e.g. over 500 tubes can produced for each type of statistic quite a lot of data and it will slow to collect and agregate them from several export instances)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case required to avoid an export of stats for each tube. It is needed when there is only interest in common stats and number of tubes can significantly increase metrics size. This could happen, for instance, in my production system where we have over 500 tubes per each VMs. 6 VMs in total. By avoiding such an export, i can remove an extra load from prometheus.