Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "ipython" enum to "tool" #261

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Rename "ipython" enum to "tool" #261

merged 1 commit into from
Jan 14, 2025

Conversation

ashwinb
Copy link
Contributor

@ashwinb ashwinb commented Jan 14, 2025

ipython is quite anachronistic. This was a bad idea to let it percolate through the APIs

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 14, 2025
Copy link
Contributor

@raghotham raghotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean all the things!

@ashwinb ashwinb merged commit fef8872 into main Jan 14, 2025
1 of 2 checks passed
@ashwinb ashwinb deleted the rename_ipython branch January 14, 2025 03:09
sixianyi0721 pushed a commit to meta-llama/llama-stack that referenced this pull request Jan 14, 2025
See meta-llama/llama-models#261 for the
corresponding PR in llama-models.

Once these PRs land, you need to work `main` from llama-models (vs. from
pypi)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants