Migrate from xz to zstd for dumps compression #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on jsonl statistics dumps which are 43G uncompressed, the results are as follows: | | xz | zstd (-10) | |-------------|--------|------------| | Compression | 8.3x | 6.7x | | Time Taken | 87m 3s | 33m 12s | xz compresses a little better but zstd is much better, and I feel the overall tradeoffs are in favour of zstd.
|
way in favor of zstd! |
mayhem
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on jsonl statistics dumps which are 43G uncompressed, the results are as follows:
xz compresses a little better but zstd is much faster, and I feel the overall tradeoffs are in favour of zstd.