include name and email in contributor index #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All contributors, including those that can't be mapped to a PAUSE author, should be included in the contributor index. This will allow the web end points to look up all contributor information via the index, rather than needing to re-calculate for each call. Adds the name and email fields to the contributor index, and populates them when calculating contributor data. The PAUSE id is no longer required, so it can't be used for the id of the ES doc. Instead, we delete all of the ids for a release before updating the data. Previously, the contributors script would ignore existing data. Now, it will delete and recreate the data. For now, the release/contributors end point will still recalculate the data for each call. After this change is deployed and all of the data is updated, it can be updated to use the contributor index and be much simpler. This will also reduce the code shared between indexing and the API.
mickeyn
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All contributors, including those that can't be mapped to a PAUSE author, should be included in the contributor index. This will allow the web end points to look up all contributor information via the index, rather than needing to re-calculate for each call.
Adds the name and email fields to the contributor index, and populates them when calculating contributor data. The PAUSE id is no longer required, so it can't be used for the id of the ES doc. Instead, we delete all of the ids for a release before updating the data. Previously, the contributors script would ignore existing data. Now, it will delete and recreate the data.
For now, the release/contributors end point will still recalculate the data for each call. After this change is deployed and all of the data is updated, it can be updated to use the contributor index and be much simpler. This will also reduce the code shared between indexing and the API.