Editor / Polygon / Fix validation error on srsName and id attributes. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since OL6 update, an srsName is added to LinearRing in GML3.2.0. GML2 OL format was not. See https://github.com/openlayers/openlayers/blame/v6.3.1/src/ol/format/GML2.js#L228 . GML3 does https://github.com/openlayers/openlayers/blob/v6.3.1/src/ol/format/GML3.js#L503 From the XSD, this attribute should probably not be added https://schemas.wmo.int/wmdr/1.0RC6/documentation/schemadoc/schemas/geometryBasic2d_xsd/elements/LinearRing.html. Workaround that issue by updating `LinearRing` in `update-fixed-info.xsl`.
josegar74
reviewed
Jun 24, 2020
| <xsl:template match="gml:Polygon[not(@gml:id) and not(@srsName)]| | ||
| gml:MultiSurface[not(@gml:id) and not(@srsName)]| | ||
| gml:LineString[not(@gml:id) and not(@srsName)]"> | ||
| <xsl:template match="gml:Polygon[not(@gml:id) or not(@srsName)]| |
There was a problem hiding this comment.
With this change the gml:id or srsName are going to be replaced if 1 of the values are not filled, should not be checked if are filled to copy them instead of setting the value?
…/ Preserve existing.
…/ Avoid xmlns attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding bounding polygon, issues are reported on validation.
Since OL6 update, an srsName is added to LinearRing in GML3.2.0.
GML2 OL format was not. See
https://github.com/openlayers/openlayers/blame/v6.3.1/src/ol/format/GML2.js#L228
.
GML3 does https://github.com/openlayers/openlayers/blob/v6.3.1/src/ol/format/GML3.js#L503
From the XSD, this attribute should probably not be added https://schemas.wmo.int/wmdr/1.0RC6/documentation/schemadoc/schemas/geometryBasic2d_xsd/elements/LinearRing.html.
Workaround that issue by updating
LinearRinginupdate-fixed-info.xsl.