Skip to content

Commit

Permalink
fix(readmapping): use more strict mapping parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
pbelmann committed Apr 24, 2024
1 parent 533b22c commit 78e60f3
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion default/fullPipelineAggregate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ steps:
# Just using relative abundance makes it difficult to tell if a genome is part of a dataset.
# Thats why it makes sense to set at leat a low min covered fraction parameter.
coverm:
additionalParams: " --min-covered-fraction 30 "
additionalParams: " --min-covered-fraction 80 --min-read-percent-identity 95 --min-read-aligned-percent 95 "
minimap:
additionalParams:
minimap_index: ""
Expand Down
14 changes: 7 additions & 7 deletions default/fullPipeline_illumina_nanpore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ steps:
# samtools flags are used to filter resulting bam file
samtoolsView: " -F 3584 "
contigsCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
genomeCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
# Primary binning tool
metabat:
# Set --seed positive numbers to reproduce the result exactly. Otherwise, random seed will be set each time.
Expand All @@ -86,9 +86,9 @@ steps:
# samtools flags are used to filter resulting bam file
samtoolsView: " -F 3584 "
contigsCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
genomeCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
metabat:
additionalParams: " --seed 234234 "
magAttributes:
Expand Down Expand Up @@ -118,7 +118,7 @@ steps:
bwa2: " "
# We demand that matches should be at least 70 percent to restrict the
# search space. We further restrict all found matches in 'coveredBasesCutoff' parameter.
coverm: " --min-covered-fraction 70 "
coverm: " --min-covered-fraction 70 --min-read-percent-identity 95 --min-read-aligned-percent 95 "
minimap: " "
samtoolsViewBwa2: " -F 3584 "
samtoolsViewMinimap: " "
Expand Down Expand Up @@ -159,7 +159,7 @@ steps:
# Just using relative abundance makes it difficult to tell if a genome is part of a dataset.
# Thats why it makes sense to set at leat a low min covered fraction parameter.
coverm:
additionalParams: " --min-covered-fraction 30 "
additionalParams: " --min-covered-fraction 80 --min-read-percent-identity 95 --min-read-aligned-percent 95 "
minimap:
additionalParams:
minimap_index: ""
Expand All @@ -180,7 +180,7 @@ steps:
additionalParams:
bwa2: " "
SCAPP: " "
coverm: " --min-covered-fraction 0 "
coverm: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
minimap: " "
samtoolsViewBwa2: " -F 3584 "
samtoolsViewMinimap: " "
Expand Down
16 changes: 8 additions & 8 deletions default/fullPipeline_illumina_nanpore_without_aggregate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ steps:
# samtools flags are used to filter resulting bam file
samtoolsView: " -F 3584 "
contigsCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
genomeCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
# Primary binning tool
metabat:
# Set --seed positive numbers to reproduce the result exactly. Otherwise, random seed will be set each time.
Expand All @@ -86,9 +86,9 @@ steps:
# samtools flags are used to filter resulting bam file
samtoolsView: " -F 3584 "
contigsCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
genomeCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
metabat:
additionalParams: " --seed 234234 "
magAttributes:
Expand Down Expand Up @@ -118,7 +118,7 @@ steps:
bwa2: " "
# We demand that matches should be at least 70 percent to restrict the
# search space. We further restrict all found matches in 'coveredBasesCutoff' parameter.
coverm: " --min-covered-fraction 70 "
coverm: " --min-covered-fraction 70 --min-read-percent-identity 95 --min-read-aligned-percent 95 "
minimap: " "
samtoolsViewBwa2: " -F 3584 "
samtoolsViewMinimap: " "
Expand All @@ -131,9 +131,9 @@ steps:
# For final reporting of the covered fraction, the --min-covered-fraction parameter is set to the same value as
# in the binning and other sections
genomeCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 95 --min-read-aligned-percent 95 "
contigsCoverage:
additionalParams: " --min-covered-fraction 0 "
additionalParams: " --min-covered-fraction 0 --min-read-percent-identity 95 --min-read-aligned-percent 95 "
annotation:
prokka:
defaultKingdom: false
Expand Down Expand Up @@ -215,7 +215,7 @@ steps:
additionalParams:
bwa2: " "
SCAPP: " "
coverm: " --min-covered-fraction 0 "
coverm: " --min-covered-fraction 0 --min-read-percent-identity 100 --min-read-aligned-percent 100 "
minimap: " "
samtoolsViewBwa2: " -F 3584 "
samtoolsViewMinimap: " "
Expand Down

0 comments on commit 78e60f3

Please sign in to comment.