feat(config): provide function to dynamically assign resources based on number of attempts #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to assign a new error handling strategy to selected processes.
Currently all processes, with the exception of Megahit, are simply retried with the same resources (CPUs, memory) assigned.
In cases where it can be foreseen that a process might need more RAM for bigger input data, the new strategy
can be assigned to the process to allow to increase the requested RAM value based on the number of execution attempts.
Development documentation has been extended regarding the usage of the new strategy.
This PR solves issue #355
PR review guidelines
Thank you for submitting this PR.
Before merge:
A PR must be reviewed by one of the team members.
Please check if anything in the documentation must be adjusted, or added (development-setup, production-setup, user-guide).
PRs with new modules or workflow interfaces must include tests according to the developer guidelines.
The new code is readable, well commented and should adhere to our developer guidelines.
Before merging it must be checked if a squash of commits is required.