Graceful shutdown #109
Open
Graceful shutdown #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertvolkmann
force-pushed
the
graceful-shutdown
branch
from
09efbe6 to
bf54db7
Compare
|
Depends on metal-stack/go-lldpd#25 |
robertvolkmann
force-pushed
the
graceful-shutdown
branch
from
de9a5b5 to
3f5f72b
Compare
iljarotar
approved these changes
Jan 29, 2025
|
Will try that in dev environment. |
|
Works in test environment, exit code 2 does not occur when stopping metal-core. |
|
Conflicts must be resolved |
robertvolkmann
force-pushed
the
graceful-shutdown
branch
from
3f5f72b to
3227620
Compare
|
Nice refactoring, appreciate that ! Should go to test for a while and the small integration test should be executed there. |
majst01
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metal-core container returns an exit code of 2 when terminated using docker stop.