Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm Chart to flipflop #11

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

jakeschuurmans
Copy link
Collaborator

In order to support our helm chart reorg and flipflop deploying

In order to support our helm chart reorg and flipflop deploying
Copy link
Contributor

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good, although I think the values.yaml currently here is a little schizophrenic, in that it looks like some values assume this chart is headed for prod and some assume the sandbox? Just had a few questions aside that.

.github/workflows/chart-release.yaml Show resolved Hide resolved
chart/templates/deployment.yaml Outdated Show resolved Hide resolved
chart/values.yaml Show resolved Hide resolved
@jakeschuurmans jakeschuurmans force-pushed the FS-1659_HelmChartAddition branch from 1e17d30 to 756858f Compare August 13, 2024 16:37
@jakeschuurmans jakeschuurmans force-pushed the FS-1659_HelmChartAddition branch from 756858f to 4ba90c1 Compare August 13, 2024 16:37
@jakeschuurmans jakeschuurmans merged commit a9bc445 into main Aug 14, 2024
4 checks passed
@jakeschuurmans jakeschuurmans deleted the FS-1659_HelmChartAddition branch August 14, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants