Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump markdownlint-cli2 to v0.12.0 #875

Merged
merged 1 commit into from
Oct 4, 2024
Merged

bump markdownlint-cli2 to v0.12.0 #875

merged 1 commit into from
Oct 4, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Oct 3, 2024

Bump markdownlint-cli2 to v0.12.0 both in local markdownlint script and in prow config for all repos.

@tuminoid
bump markdownlint-cli2 to v0.12.0
ea67c8c 
Bump markdownlint-cli2 to v0.12.0 both in local markdownlint script
and in prow config for all repos.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member Author

tuminoid commented Oct 3, 2024

/hold
Until all repos specific bumps are ready.

@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 3, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Oct 3, 2024

/hold Until all repos specific bumps are ready.

/unhold
all PRs are done.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Oct 3, 2024

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Rozzii
Rozzii reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Rozzii
Rozzii reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
adilGhaffarDev
adilGhaffarDev approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@adilGhaffarDev
Copy link
Member

cc @mboukhalfa @kashifest

kashifest
kashifest reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@metal3-io-bot metal3-io-bot merged commit 45f150c into metal3-io:main Oct 4, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-markdownlint-cli2 branch October 4, 2024 07:44
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Bump markdownlint-cli2 to v0.12.0 both in local markdownlint script and in prow config for all repos.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@kashifest kashifest kashifest left review comments

@adilGhaffarDev adilGhaffarDev adilGhaffarDev approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @adilGhaffarDev @Rozzii @kashifest